[FFmpeg-devel] [PATCH]Do not free non-allocated memory

[Måns Rullgård]

Reimar D?ffinger <Reimar.Doeffinger at gmx.de> writes:

> On Sat, Oct 17, 2009 at 10:11:23PM +0200, Michael Niedermayer wrote:
>> On Fri, Oct 16, 2009 at 05:40:47PM +0200, Reimar D?ffinger wrote:
>> > On Fri, Oct 16, 2009 at 06:14:11PM +0300, Kostya wrote:
>> > > On Fri, Oct 16, 2009 at 05:00:53PM +0200, Carl Eugen Hoyos wrote:
>> > > > Hi!
>> > > >
>> > > > As spotted by Alex Converse in a patch I sent recently. I believe his  
>> > > > comment is also true for these files.
>> > > >
>> > > > Please comment, Carl Eugen
>> > > 
>> > > Indeed, seems so.
>> > > Please apply.
>> > 
>> > Maybe someone could be convinced to write a test program that just calls
>> > init() and close() or whatever it is called on all "things" (codecs,
>> > muxers,...) that would allow to easily spot such things with valgrind?
>> 
>> and/or run the regression tests or fate under valgrind
>
> - will take really, really long, there is no way you can get people
>   to run it before every commit, and running FATE like this would make
>   it slow down enough that e.g. the AVR32 targets would be able to
>   test far fewer revisions and with far more delay

We'd obviously it on a fast machine.  Valgrind works only on x86 and
ppc anyway.

> - will not test the codecs without regression test, i.e. it would have found
>   almost none of those where there was an issue

Are they covered by FATE?

> - the errors will be hidden in the middle of thousands of lines of
>   other output

That's a problem.  Can Valgrind be made to return an error code if
there were leaks/errors?

-- 
M?ns Rullg?rd
mans at mansr.com