[FFmpeg-devel] [PATCH] fix sdp(file) vs rtsp dep

[Luca Abeni]

Hi Luca,

On Sun, 2009-10-18 at 01:59 +0200, Luca Barbato wrote:
> Diego pointed out that there was something wrong with the deps between
> the sdp and the rtsp demuxer.
> 
> The sdp demuxer is just the rtsp demuxer that instead of fetching the
> stream description through rtsp it just read it from a plain file.
> 
> That said the attached patches fix the missing symbols at link if the
> rtsp demuxer is disabled and the sdp demuxer enabled.

I agree that this should be fixed. 

Only one comment:
[...]
> diff --git a/configure b/configure
> index 0a44b14..1042bf6 100755
> --- a/configure
> +++ b/configure
> @@ -1200,8 +1200,8 @@ mxf_d10_muxer_select="mxf_muxer"
>  psp_muxer_select="mov_muxer"
>  redir_demuxer_deps="network"
>  rtp_muxer_deps="network rtp_protocol"
> -rtsp_demuxer_deps="sdp_demuxer"
> -sdp_demuxer_deps="rtp_protocol mpegts_demuxer"
> +rtsp_demuxer_deps="rtp_protocol mpegts_demuxer"
> +sdp_demuxer_deps="rtsp_demuxer"

I think these dependencies are correct as they are now: the RTSP demuxer
depends on the SDP demuxer, and not vice-versa (or, if you prefer, the
RTSP demuxer is a superset of the SDP demuxer). From the practical point
of view, I do not think this makes any difference, but from the
theoretical point of view I think it's better to indicate the correct
dependency here.

			Luca