[FFmpeg-devel] [PATCH] Add functions shared by AMR and SIPR

[Diego Biurrun]

On Mon, Oct 19, 2009 at 01:41:19AM +0200, Vitor Sessak wrote:
> 
> The SIPR decoder shares quite a few code with AMR. Most of those 
> functions are copied from the last AMR patch in -devel. An exception is 
> ff_acelp_interpolatef(), that was copied from a fixed-point version and 
> is used in AMR in the function interp_pitch_vector().

Progress for AMR - nice.

> --- libavcodec/lsp.h	(revision 20260)
> +++ libavcodec/lsp.h	(working copy)
> @@ -40,6 +40,19 @@
>  
> + * This step isn't mentioned in the AMR spec but is in the reference C decoder.

is not

> --- libavcodec/acelp_filters.h	(revision 20260)
> +++ libavcodec/acelp_filters.h	(working copy)
> @@ -97,4 +105,15 @@
> + * apply tilt compensation filter, 1 - tilt * z-1

Capitalize, add period.

> + * @param mem pointer to one float to keep the filter's state

I'd just say "filter state" here.

Diego