[FFmpeg-devel] [PATCH] turn off deinterlace if not supported by avpicture_deinterlace

[Michael Niedermayer]

On Mon, Oct 19, 2009 at 10:06:31AM +0300, Maksym Veremeyenko wrote:
> Michael Niedermayer ???????(??):
>> On Sun, Oct 18, 2009 at 07:53:12PM +0300, Maksym Veremeyenko wrote:
>>> Hi,
>>>
>>> Attached patch turn off deinterlace flag is avpicture_deinterlace do not 
>>> support given pixel format. Try to avoid message error "Deinterlacing 
>>> failed\n" for each frame.
>> deinterlace should not fail, thats a bug
> from imgconvert.c:
> [...]
> int avpicture_deinterlace(AVPicture *dst, const AVPicture *src,
>                           enum PixelFormat pix_fmt, int width, int height)
> {
>     int i;
>
>     if (pix_fmt != PIX_FMT_YUV420P &&
>         pix_fmt != PIX_FMT_YUV422P &&
>         pix_fmt != PIX_FMT_YUV444P &&
>         pix_fmt != PIX_FMT_YUV411P &&
>         pix_fmt != PIX_FMT_GRAY8)
>         return -1;

avpicture_deinterlace() is crap anyway, mplayer and libpostproc have nicer
deinterlacers


> [...]
> it's seen that video supplied with PIX_FMT_YUVJ422P not supported. in my 
> case video recorded by digital photo camera. Also there are could be 
> other...
>
> may be it has a sense to add support of PIX_FMT_YUVJ422P if it similar to 
> PIX_FMT_YUV422P:

fine but as said this is all pretty much dead code, there are better
deinterlacers that should be ported to libavfilter

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Democracy is the form of government in which you can choose your dictator
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20091019/d095a8d1/attachment.pgp>