[FFmpeg-devel] [PATCH] Add writing of vorbis comments to flac files

[James Darnley]

Okay, updated patch attached.  Writing comments to ogg files will be
another patch because while it seems simple to write tags for flac and
speex, I still need to test them.  And if you use vorbis or libvorbis
then it seems the comments are written at libavcodec/vorbis_enc.c:553
and libvorbis.c:99 respecively.


2009/10/22 Justin Ruggles <justin.ruggles at gmail.com>:
>> ?static int flac_write_header(struct AVFormatContext *s)
>> ?{
>> - ? ?return ff_flac_write_header(s->pb, s->streams[0]->codec);
>> + ? ?int ret;
>> + ? ?AVCodecContext *codec = s->streams[0]->codec;
>> + ? ?/* unsigned int dur = 0; /* see comment below
>> + ? ?av_log(NULL, AV_LOG_ERROR, "[flac tags] duration=%d\n", dur);*/
>
>
> the 2 lines are still there...
>
*hurr*  Definitely fixed now

> you need to use doxygen comments for the documentation, including
> documentation of each parameter.
> mention that m can be NULL.
> mention that vendor_string cannot be NULL but it can be an empty string.
>
Done, I hope this is the correct format.  I copied from some of the
comments in avformat.h
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ffmpeg_flac-tags_13_r20344M.diff
Type: application/octet-stream
Size: 13666 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20091022/4ab9671d/attachment.obj>