[FFmpeg-devel] [PATCH] support for hardcoded mpegaudiodec tables

[Reimar Döffinger]

On Thu, Oct 22, 2009 at 08:58:32PM +0200, Michael Niedermayer wrote:
> On Thu, Oct 22, 2009 at 09:04:08AM +0200, Reimar D?ffinger wrote:
> > No, that isn't possible, unless you suggest to duplicate the whole loop
> > and calculation just to first calculate the values and then the exponents.
> 
> you turn every tiny problem into a mountain

No, I try to figure out how your suggestions are supposed to lead to a
solution that is overall and in the long term _less_ ugly than what I propose,
and so far I just see one hack piling onto the next one.
Maybe it all fits together nicely in your brain, but not in mine.
I'll see if I can finish my other approach anytime soon, though as
far as I have it in my mind it would end up with one common .c and .h file,
and at least one per .c and .h file per "table group" and be a
bit more complex than I'd really like.

> > Also just using printf does not work if you want the generated file not to
> > look like a complete mess.
> 
> IMHO the generated file is not for human consumtion, its just an
> intermediate to get the table into the object file
> but nothing stops one to do a
> if(++x % 8 ==0) printf("\n");
> as well

Well, I admit I've never tested it since years, I just remember that
in the past some compilers did not accept arbitrary-size lines (at least
not in the area of MBs).