[FFmpeg-devel] PATCH rtsp/sdp/multicast

[armand bendanan]

> -----Original Message-----
> From: ffmpeg-devel-bounces at mplayerhq.hu [mailto:ffmpeg-devel-
> bounces at mplayerhq.hu] On Behalf Of Diego Biurrun
> Sent: jeudi 22 octobre 2009 13:35
> To: FFmpeg development discussions and patches
> Subject: Re: [FFmpeg-devel] PATCH rtsp/sdp/multicast
> 
> Your Outlook is producing the most ugly mail formatting imaginable.  I
> suggest you get (any) other mail client as a replacement.
> 
> Also, remember that top-posting is not allowed here.
> 
> On Wed, Oct 21, 2009 at 10:03:03PM +0200, armand bendanan wrote:
> >
> > --- old/libavformat/rtsp.c	2009-10-21 19:47:39.000000000 +0200
> > +++ ffmpeg/libavformat/rtsp.c	2009-10-21 20:06:59.000000000 +0200
> > @@ -1125,12 +1125,24 @@
> >                  char url[1024];
> >                  struct in_addr in;
> > +                int port;
> > +                int ttl;
> 
> Merge this into one line.
> 
> > +            		port = reply->transports[0].port_min;
> > +            		ttl = reply->transports[0].ttl;
> 
> The '=' could be aligned.
> 
> > +            		in = rtsp_st->sdp_ip;
> > +            		port = rtsp_st->sdp_port;
> > +            		ttl = rtsp_st->sdp_ttl;
> 
> same here
> 
> >                  snprintf(url, sizeof(url), "rtp://%s:%d?ttl=%d",
> >                           inet_ntoa(in),
> > -                         reply->transports[0].port_min,
> > -                         reply->transports[0].ttl);
> > +                         port,
> > +                         ttl);
> 
> shorter:
> 
>   snprintf(url, sizeof(url), "rtp://%s:%d?ttl=%d",
>            inet_ntoa(in), port, ttl);
> 
> Also, get rid of all the tabs.

Here is the new corrected patch.
Armand

 

__________ Information from ESET NOD32 Antivirus, version of virus signature
database 4535 (20091023) __________

The message was checked by ESET NOD32 Antivirus.

http://www.eset.com
 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patchabe_1.diff
Type: application/octet-stream
Size: 1843 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20091023/6370507c/attachment.obj>