[FFmpeg-devel] [PATCH] remove pnm code cruft

Michael Niedermayer michaelni
Tue Oct 27 14:49:02 CET 2009


On Tue, Oct 27, 2009 at 01:58:53PM +0100, Diego Biurrun wrote:
> On Tue, Oct 27, 2009 at 01:49:42PM +0100, Michael Niedermayer wrote:
> > On Tue, Oct 27, 2009 at 10:44:12AM +0000, M?ns Rullg?rd wrote:
> > > Michael Niedermayer <michaelni at gmx.at> writes:
> > > 
> > > > On Tue, Oct 27, 2009 at 11:06:03AM +0100, Diego Biurrun wrote:
> > > >> This removes some cruft from pnmenc.c.  I intend to split the file
> > > >> afterwards, so removing cruft seems like a good first step.
> > > >
> > > > instead of removing the probe code, the code should be used
> > > 
> > > That code is a remnant from when this file was in lavf.
> > 
> > yes
> > 
> > >  It should be deleted.
> > 
> > no
> > Id like to have functioning image2 probing.
> 
> I'd like to have a pony.

I'd like all ponies to live their lives in freedom in their natural
habitat.


> 
> > This code should be exported from the decoder (AVCodec.probe maybe)
> > and then img2.c image_probe() should call that for all image codecs
> > for probing instead of pure filename extension based probing.
> 
> Do it.  If you haven't done it by next week, I will just delete the
> non-compiling cruft, since it will never be used nor repaired.

Have you not considered that i could maybe implement it after next week
after reading your prediction? ;)

Seriously, ill look at implementing this one if that makes you happy
it should be quite trivial

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have never wished to cater to the crowd; for what I know they do not
approve, and what they approve I do not know. -- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20091027/73497f82/attachment.pgp>



More information about the ffmpeg-devel mailing list