[FFmpeg-devel] [PATCH][RFC] Lagarith Decoder.

[Vitor Sessak]

Nathan Caldwell wrote:
> Here are the latest lagarith patches.
> I renamed the range coder to lagarithrac.{c,h}

A few comments:

> +static av_cold int lag_decode_init(AVCodecContext *avctx)
> +{
> +    LagarithContext *l = avctx->priv_data;
> +
> +    l->avctx = avctx;
> +
> +    return 0;
> +}

This function does nothing. Just set the AVCoded field to NULL.

> +
> +/**
> + * @file libavcodec/lagarith.h
> + * Lagarith lossless decoder
> + * @author Nathan Caldwell
> + *
> + */

This header is only included in lagarith.c, so unless there is a
reason to expect this to be used in other files in the future, it is
better to remove this file and move the definition to lagarith.c.

> +        av_log(avctx, AV_LOG_ERROR,
> +               "Unsupported Lagarith frame type: %#x\n", frametype);

Maybe av_log_missing_feature()?

-Vitor