[FFmpeg-devel] [PATCH] mov reference files search improvement

Diego Biurrun diego
Wed Sep 2 10:44:41 CEST 2009


On Wed, Sep 02, 2009 at 09:55:32AM +0300, Maksym Veremeyenko wrote:
> 
> --- libavformat/mov.c	(revision 19698)
> +++ libavformat/mov.c	(working copy)
> @@ -1513,6 +1538,115 @@
>  
> +    /* build relative */
> +    if(ref->file_name)
> +    {

if (ref->file_name) {

> +        /* find path */
> +        pos = FFMAX(strrchr(filename, '/'), strrchr(filename, '\\'));
> +        if(NULL == pos)

if (!pos)

> +        if(ref->directory_name)

if (

more below

> +        av_log(c->fc, AV_LOG_ERROR, "stream %d, alias not resolved, probed list [%s]\n",
> +            idx, probed);

indentation


You have some needlessly long lines in there that you could easily
break.

Diego



More information about the ffmpeg-devel mailing list