[FFmpeg-devel] [PATCH] atrac1 decoder and aea demuxer

[Benjamin Larsson]

Reimar D?ffinger wrote:
> [...]
>   
>> +        /* Check so that values are != 0 */
>> +        checksum = bsm_s + bsm_e + inb_s + inb_e;
>> +        if (checksum)
>> +            if ((bsm_s == bsm_e) && (inb_s == inb_e) && (bsm_s != inb_s))
>>     
>
> Huh, what?
> Is that meant to be
> if (bsm_s && bsm_e && bsm_s == bsm_e && inb_s == inb_e && bsm_s != inb_s)
>
> written by someone who likes obfuscation too much?
> If not it seriously needs some more comments/explanations.
>
>   

The block switch mode and info byte are repeated in an atrac frame. But 
they are never the same value. Hope that explains the code.

>> +    /* First packet starts at 0x800 */
>> +    url_fskip(s->pb, 264);
>>     
>
> You know, in my opinion comments should ease understanding, not confuse
> like this one does.
>
>   
Did you ran out of crystal balls ? :)

>   
>> +    pcm_read_seek,
>> +    .flags= AVFMT_GENERIC_INDEX,
>>     
>
> does seeking actually work right? I would have thought you'd have to set
> data_offset right for that.
>   
Seeking works.

MvH
Benjamin Larsson