[FFmpeg-devel] [PATCH] ALS decoder

[Reimar Döffinger]

On Thu, Sep 03, 2009 at 08:19:24PM +0200, Diego Biurrun wrote:
> On Thu, Sep 03, 2009 at 07:57:21PM +0200, Thilo Borgmann wrote:
> > +#ifdef DEBUG
> > +static av_cold void dprint_specific_config(ALSDecContext *ctx)
> > +{
> > +    AVCodecContext *avctx    = ctx->avctx;
> > +    ALSSpecificConfig *sconf = &ctx->sconf;
> > +
> > +    dprintf(avctx, " num_frames = %i\n",          ctx->num_frames);
> > +    dprintf(avctx, " last_frame_length = %i\n",   ctx->last_frame_length);
> > +}
> > +#endif
> 
> Wild idea: Maybe this could be an empty function if DEBUG is not set?

I actually would be quite in favour of making DEBUG 0/1 and doing
if (!DEBUG)
  return;

The reason: A lot of debug code in FFmpeg just doesn't compile anymore,
doing it like this ensures the code will still be tested for compilation.