[FFmpeg-devel] [PATCH] ALS decoder

[Thilo Borgmann]

>> +    config_offset = ff_mpeg4audio_get_config(&m4ac, buffer, avctx->extradata_size);
> 
> long line
> 
>> +    // read fixed header and trailer sizes, if size = 0xFFFFFFFF then there is no data field!
> 
> long line
> 
>> +/** Parses the bs_info field to extract the block partitioning used in block switching mode,
>> + *  refer to ISO/IEC 14496-3, section 11.6.2.
> 
> ditto
> 
>> +static void parse_bs_info(const uint32_t bs_info, unsigned int n, unsigned int div,
>> +                          unsigned int **div_blocks, unsigned int *num_blocks)
> 
> ditto
> 
>> +/** Reformat block sizes from log2 format to direct form. Also assure that the
>> + *  block sizes of the last frame correspond to the actual number of samples.
> 
> ditto
> 
>> +    // store carryover raw samples, the others channel raw samples are stored by the calling function.
> 
> ditto
> 

I thought it is allowed to get beyond 80 chars if readability will
profit from this quite a bit.
In the first case, the line exceeds the 80 by 3 chars but gains a lot of
readability, for example.

So how crucial is the 80-chars-rule?

Thanks!

-Thilo