[FFmpeg-devel] [PATCH] remove disabled code part 1

[Reimar Döffinger]

On Fri, Sep 04, 2009 at 01:33:23PM -0300, Ramiro Polla wrote:
> On Fri, Sep 4, 2009 at 1:20 PM, Aurelien Jacobs<aurel at gnuage.org> wrote:
> > On Fri, Sep 04, 2009 at 12:29:43PM -0300, Ramiro Polla wrote:
> >> > It's a straight road into accumulating cruft.  Also, it will never get
> >> > compiled and quickly fail to compile.  Just look at some of the code we
> >> > have or had under '#if 0'...
> >>
> >> How will any of that be any different with "#if DEBUG_VFW"?
> >
> > I agree.
> > If you don't want the debug code to rot, just use if(0){}.
> 
> Done, thanks for the tip.

Note that DEBUG_... has the advantage that with a
#define DEBUG_... 0
at the top it is obvious what debugging stuff is available as well
as searching for debug code.
With #if 0 that's a bit harder, and with if (0) { it means using a
regexp (unless we make more of an effort to do 100% consistent
whitespace placement).