[FFmpeg-devel] [PATCH] Store Major brand, Minor version and compatible brands of a mov file using the metadata API

[Diego Biurrun]

On Sun, Sep 06, 2009 at 06:16:33PM +0300, haim alon wrote:
> This patch fetches the Major brand, Minor version and compatible brands of a
> mov file, and stores them in the AVFromatContext using the metadata API.
> This feature enables application to retrieve this mov file information using
> corresponding metadata API, before further processing.

Get rid of the tabs and the trailing whitespace.

> --- libavformat/mov.c	(revision 19787)
> +++ libavformat/mov.c	(working copy)
> @@ -485,15 +485,50 @@
>  
> +    int bnum,numCT,i;
> +    memcpy(majorBrandStr,&type,4); /*set major version to majorBrandStr*/

Spaces after commas please, this is unreadable, same below.

> +    numCT = (atom.size - 8)/4;

.. and around / ..

> +    for (i=0; i<numCT;i++) { /*compatible brands*/	  

for (i = 0; i < numCT; i++) { /* compatible brands */

> +    if (bnum != numCT) {	// skip unhandled compatible brands
> +        url_fskip(pb,(bnum-numCT)*4);		
> +    }

pointless {}

Diego