[FFmpeg-devel] [PATCH] ALS decoder

[Diego Biurrun]

On Mon, Sep 07, 2009 at 01:23:07AM +0200, Thilo Borgmann wrote:
> Revision 17 attached.
> 
> --- libavcodec/alsdec.c	(revision 0)
> +++ libavcodec/alsdec.c	(revision 0)
> @@ -0,0 +1,1041 @@
> +/*
> + * ALS decoder
> + */
> +
> +/**
> + * @file libavcodec/alsdec.c
> + * MPEG-4 ALS decoder

Write MPEG-4 ALS decoder in both places.

> +    unsigned int sub_blocks, log2_sub_blocks, sb_length;

I'd say "subblocks".

> +        av_log(avctx, AV_LOG_WARNING,
> +               "Block length is not evenly divisible by the number of sub blocks.\n");

same here

> +            // if joint_stereo and block_switching is set, independent decoding
> +            // is signaled via the first bit of bs_info
> +            if (sconf->joint_stereo && sconf->block_switching) {
> +                if (bs_info >> 31)
> +                    independent_bs = 2;
> +            }

pointless {}

> --- libavcodec/als_data.h	(revision 0)
> +++ libavcodec/als_data.h	(revision 0)
> @@ -0,0 +1,95 @@
> +/*
> + * ALS header file for common data
> + */
> +
> +/**
> + * @file libavcodec/als_data.h
> + * MPEG-4 ALS header file for common data

This sentence tells you that I can see it is a header file from the
filename already.

See the redundancy?

Diego