[FFmpeg-devel] Slice direction in swscale.

[Ramiro Polla]

On Mon, Sep 7, 2009 at 3:31 AM, Ramiro Polla<ramiro.polla at gmail.com> wrote:
> In sws_scale() there is some code to adjust src and srcStride if it
> seems the slices go from bottom to top. This is traced back to r15249,
> and the discussion leading to the patch is here:
> http://thread.gmane.org/gmane.comp.video.mplayer.devel/25600/focus=25615
>
> I have also stumbled upon this:
> http://thread.gmane.org/gmane.comp.video.ffmpeg.devel/42415
>
> I have not been able to test this code, not even with the sample
> pointed at the first link above. The sample plays something very
> distorted in ffplay, something with a badly scaled chroma in mplayer,
> and plays properly in vlc.
>
> Does anyone know of a sample that triggers code? Certainly it's not
> with ffmpeg/ffplay, since we run sws_scale on the whole picture
> instead of slice-based, but I suppose this could be tested with
> mplayer.
>
> Anyways the sliceDir check is very hackish and undocumented. Would it
> be acceptable for this to be removed and always require top-to-bottom
> strides or expect the user to flip things himself?

Alternatively we could document it with attached patch.

Ramiro Polla
-------------- next part --------------
A non-text attachment was scrubbed...
Name: document_slices.diff
Type: text/x-diff
Size: 592 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090908/7f6efb48/attachment.diff>