[FFmpeg-devel] [PATCH v2] add put_bits_long to avoid undefined behaviour in put_bits
Diego Biurrun
diego
Wed Sep 9 07:24:24 CEST 2009
On Tue, Sep 08, 2009 at 07:58:35PM +0000, matthieu CASTET wrote:
> Diego Biurrun <diego <at> biurrun.de> writes:
>
> > On Tue, Aug 25, 2009 at 09:45:08PM +0200, matthieu castet wrote:
> > >
> > > put_bits(&s->pbctx, 1, is_verbatim);
> > > - put_bits(&s->pbctx, 32, s->avctx->frame_size);
> > > + put_bits_long(&s->pbctx, 32, s->avctx->frame_size);
> >
> > This should remain aligned.
> >
> What do you suggest ?
That the comments on the right side of those lines, which for some
unfathomable reason you removed from the quote above, should remain
aligned.
Diego
More information about the ffmpeg-devel
mailing list