[FFmpeg-devel] [PATCH] support for UTF-16 encoding in id3v2 tags

[Reimar Döffinger]

On Sat, Sep 12, 2009 at 02:28:04PM +0200, Michael Niedermayer wrote:
> On Fri, Sep 11, 2009 at 10:33:37AM +0200, Anton Khirnov wrote:
> >  libavformat/id3v2.c |   28 ++++++++++++++++++++++++++++
> >  libavutil/common.h  |   26 ++++++++++++++++++++++++++
> >  2 files changed, 54 insertions(+)
> > 7b92620d0bf5540720a56bc7adb34b7d4f238543  0001-id3v2-add-support-for-UTF-16-encoding.patch
> > From 2c8cb43ec213c2e604b133ab773aed03d22c1686 Mon Sep 17 00:00:00 2001
> > From: Anton Khirnov <wyskas at gmail.com>
> > Date: Sun, 6 Sep 2009 13:34:48 +0200
> > Subject: [PATCH] id3v2: add support for UTF-16 encoding.
> 
> ok if tested and reimar has no further comments

Unfortunately I had. I know they are rather nit-pickish, but this kind
of macros are very ugly and easy to use wrongly, I don't want the
probability for incorrect usage to increase even further because GET_UTF8 and
GET_UTF16 have subtle differences.