[FFmpeg-devel] [PATCH] support for UTF-16 encoding in id3v2 tags

[Anton Khirnov]

On Sat, Sep 12, 2009 at 06:47:34PM +0200, Reimar D?ffinger wrote:
> 
> Seven is the documented maximum of PUT_UTF8, for anything else you are
> making assumptions like e.g. there is no accidental sign expansion and
> generally you rely on undocumented behaviour.
> Given that it "saves" maximum 5 bytes that seems like a rather silly
> "optimization" given it is security-relevant code.
> I think I have no other comments beyond that.

ok, fixed

Anton Khirnov
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-id3v2-check-for-enough-space-to-write-full-UTF-8-cha.patch
Type: text/x-diff
Size: 940 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090912/d9c3e9c4/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-id3v2-use-0-instead-of-0.patch
Type: text/x-diff
Size: 699 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090912/d9c3e9c4/attachment-0001.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-id3v2-add-support-for-UTF-16-encoding.patch
Type: text/x-diff
Size: 3314 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090912/d9c3e9c4/attachment-0002.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090912/d9c3e9c4/attachment.pgp>