[FFmpeg-devel] [PATCH] Altivec split-radix FFT

Måns Rullgård mans
Tue Sep 15 16:13:19 CEST 2009


Loren Merritt <lorenm at u.washington.edu> writes:

> On Fri, 28 Aug 2009, M?ns Rullg?rd wrote:
>> Reimar D?ffinger <Reimar.Doeffinger at gmx.de> writes:
>>> On Fri, Aug 28, 2009 at 10:02:35AM +0200, Guillaume POIRIER wrote:
>>>>
>>>> It indeed now works on Linux/PPC64 and Linux/PPC32, but still not on OSX/PPC*.
>>>>
>>>> Do you think that gas' .macro functionalities could allow to make your
>>>> ASM portable across both Linux and OSX, defining each register Rx as
>>>> either rx on OSX, and x on all the other platforms that use FSF tools?
>>>
>>> It is preprocessed anyway, you can just define REG_1... REG_n in a
>>> header and in include that in both C and asm files.
>>
>> I'd just #define r1 1 etc for the cases that prefer numbers over
>> names.
>
> Avoided .ifb.
>
> Fixed register names (untested).
> The manually unrolled list is ugly, but I can't find a gas equivalent
> to yasm's ability to expand macros in macro names.

Can you elaborate on that?

> Are the other configure checks for ppc asm broken? Some use register
> names and some don't, and I don't think this is what they're supposed
> to be detecting.
> When the first reg of an address is being a literal zero rather than a
> register, should it be named?

I suggest writing literal zeros as a digit zero (0) if the assembler
accepts this.

> Didn't change .rodata. Is there some version-dependent define for that?
> Or same/another configure check?

What is the problem with .rodata again?

-- 
M?ns Rullg?rd
mans at mansr.com



More information about the ffmpeg-devel mailing list