[FFmpeg-devel] [PATCH] add small sizes to ff_sine_windows[] array

[Vitor Sessak]

Michael Niedermayer wrote:
> On Mon, Sep 14, 2009 at 06:34:41PM +0200, Vitor Sessak wrote:
>> Reimar D?ffinger wrote:
>>> On Mon, Sep 14, 2009 at 06:09:46PM +0200, Vitor Sessak wrote:
>>>> Hi,
>>>>
>>>> This should fix issue 1384 with TwinVQ decoder. I could add just a couple 
>>>> of sizes, but I think that adding all the seven are worth it to 
>>>> completely avoid this kind of error in the future. It also IMHO improves 
>>>> of clarity of the resulting code, for example:
>>>>
>>>>> -    ff_sine_window_init(ff_sine_windows[av_log2(mtab->size) - 7], 
>>>>> mtab->size);
>>>>> +    ff_sine_window_init(ff_sine_windows[av_log2(mtab->size)], 
>>>>> mtab->size);
>>> Personally, I'd be in favour of expanding ff_sine_windows to have space
>>> for all, but set the unused parts to NULL.
>> Fine by me. New patch attached.
>>
>> -Vitor
> 
>>  dsputil.h   |    4 +++-
>>  mdct.c      |    6 +++++-
>>  twinvq.c    |    8 ++++----
>>  wma.c       |    4 ++--
>>  wmaprodec.c |    2 +-
>>  5 files changed, 15 insertions(+), 9 deletions(-)
>> c62415bc1e634802d5a2461554357217f31668f6  sine_win2.diff
> 
> ok

Applied.

-Vitor