[FFmpeg-devel] [PATCH] MPEG-2 encoding of large frames

[Michael Niedermayer]

On Wed, Sep 16, 2009 at 07:32:59PM +0200, Martin Fiedler wrote:
> Hi!
> 
> When trying to encode MPEG-2 video with a vertical resolution of more than
> 2800 lines, libavcodec currently generates broken bitstreams because the
> slice_vertical_position_extension field is missing. The attached patch
> fixes this problem.
> 
> Best regards,
> 
> Martin J. Fiedler
>  mpeg12enc.c |    7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 568989d0098c26d249a622d0f4155367258306ab  mpeg2enc-large-frames.patch
> Index: libavcodec/mpeg12enc.c
> ===================================================================
> --- libavcodec/mpeg12enc.c	(revision 19880)
> +++ libavcodec/mpeg12enc.c	(working copy)
> @@ -327,7 +327,12 @@
>  }
>  
>  void ff_mpeg1_encode_slice_header(MpegEncContext *s){
> +    if ((s->codec_id == CODEC_ID_MPEG2VIDEO) && (s->height > 2800)) {

superflous ()

[...]

> -    put_header(s, SLICE_MIN_START_CODE + s->mb_y);
> +        put_header(s, SLICE_MIN_START_CODE + s->mb_y);

should be a seperate patch maybe

otherwise ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The bravest are surely those who have the clearest vision
of what is before them, glory and danger alike, and yet
notwithstanding go out to meet it. -- Thucydides
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090916/621577b7/attachment.pgp>