[FFmpeg-devel] [PATCH] flush_put_bits_cache

[Michael Niedermayer]

On Wed, Sep 16, 2009 at 03:24:12PM +0200, Sascha Sommer wrote:
> Hi,
> 
> On Sonntag, 13. September 2009, Michael Niedermayer wrote:
> > On Sat, Aug 29, 2009 at 01:36:45PM +0200, Sascha Sommer wrote:
> > > Hi,
> > >
> > > attached patch adds an alternate way of flushing the put bits buffer.
> > > The new function makes it possible to access a put bits buffer till the
> > > last bit without loosing the possibility to still append some more bits
> > > at the position of the last write.
> >
> > why do we need 2 such functions with slightly different semantics?
> 
> We don't need both. The new function could be made the default for 
> flush_put_bits. The old behaviour could be emulated by calling align_put_bits 
> before flush_put_bits.

is any code depending on the old behaviour?


> 
> > why is it inline in a header? is it speed critical
> >
> 
> The only reason it is inline in the header is that the other function was also 
> declared like this.

thats a weak reason

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In a rich man's house there is no place to spit but his face.
-- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090916/a52e92b4/attachment.pgp>