[FFmpeg-devel] Adding Teletext Tags to mpeg TS demuxer

[Baptiste Coudurier]

Hi,

On 09/18/2009 12:50 PM, Reimar D?ffinger wrote:
> On Fri, Sep 18, 2009 at 06:09:50PM +0200, Alwin Esch wrote:
>> the attached patch adding codec Id's for mpeg TS streams which including
>> Teletext data. The changes to parse the TS stream inside mpegts.c is only a
>> extension of the "static const StreamType DESC_types[]" table with the ID's
>> taken from ETSI EN 300 468 V1.5.1 (Digital Video Broadcasting (DVB);
>> Specification for Service Information (SI) in DVB systems). Due to that
>> inside avcodec.h no Data Codec section is present I add the ID's to 0x17500,
>> hope this is acceptable.
>>
>> It is required for adding Teletext support to XBMC, see Ticket
>> http://www.xbmc.org/trac/ticket/7187 on XBMC trac.
>
> This conflicts a bit with a patch I have in my local try. While it can
> be considered a bit of a stretch, I think these might better be handled
> as subtitle streams (particularly since teletext can also encode
> subtitles). In particular, your patch also does not parse the language
> from the teletext stream.
>

It seems CODEC_ID_EBU_TELETEXT might be more correct if it is really 
defined by EBU and not DVB. Subtitle type makes more sense indeed, the 
rest of the patch is ok (language..)

I'm not sure about VBI_DATA though, it's more data IMHO ;)

-- 
Baptiste COUDURIER
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
FFmpeg maintainer                                  http://www.ffmpeg.org