[FFmpeg-devel] [PATCH] MPEG-2 encoding of large frames

[Michael Niedermayer]

On Thu, Sep 17, 2009 at 07:00:39AM +0200, Martin Fiedler wrote:
> On Wed, 16 Sep 2009 20:39:09 +0200
> Michael Niedermayer <michaelni at gmx.at> wrote:
> 
> > >  void ff_mpeg1_encode_slice_header(MpegEncContext *s){
> > > +    if ((s->codec_id == CODEC_ID_MPEG2VIDEO) && (s->height > 2800)) {
> > 
> > superflous ()
> 
> OK. I removed the codec ID check completely, because after having re-read
> the spec, nothing suggests that slice_vertical_position_extension is
> specific to MPEG-2.
> 
> > > -    put_header(s, SLICE_MIN_START_CODE + s->mb_y);
> > > +        put_header(s, SLICE_MIN_START_CODE + s->mb_y);
> > 
> > should be a seperate patch maybe
> 
> I don't get that. It's not just a cosmetic change: the line has been
> indented because it's now in the else{} clause.
> 
> I attached a slightly updated patch.
> 
> Best regards,
> 
> Martin J. Fiedler
>  mpeg12enc.c |    7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 6db29f5aed6f57172f6e43b1dedd05c9f695777f  mpeg2enc-large-frames.rev2.patch

ok

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I know you won't believe me, but the highest form of Human Excellence is
to question oneself and others. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090920/04b79014/attachment.pgp>