[FFmpeg-devel] [PATCH 2/2] Move MDCT function pointers to MDCTContext

[Måns Rullgård]

M?ns Rullg?rd <mans at mansr.com> writes:

> Reimar D?ffinger <Reimar.Doeffinger at gmx.de> writes:
>
>> On Sun, Sep 20, 2009 at 03:11:30PM +0100, M?ns Rullg?rd wrote:
>>> diff --git a/libavcodec/dsputil.h b/libavcodec/dsputil.h
>>> index 985120e..88a0ee8 100644
>>> --- a/libavcodec/dsputil.h
>>> +++ b/libavcodec/dsputil.h
>>> @@ -687,6 +687,9 @@ typedef struct FFTContext {
>>>      void (*imdct_half)(struct FFTContext *s, FFTSample *output, const FFTSample *input);
>>>      void (*mdct_calc)(struct FFTContext *s, FFTSample *output, const FFTSample *input);
>>>      int split_radix;
>>> +    int permutation;
>>> +#define FF_MDCT_PERM_NONE       0
>>> +#define FF_MDCT_PERM_INTERLEAVE 1
>>>  } FFTContext;
>>>  
>>>  extern FFTSample* const ff_cos_tabs[13];
>>
>> No real opinion except that I think an enum fits better how it is used
>> than defines.
>
> I can change it to an enum if that's desired.  Any other comments?

Apparently not, so applied with the #defines because I'm lazy.  If
anyone dislikes them, he is welcome to send a patch changing not only
these, but all the others like them.

-- 
M?ns Rullg?rd
mans at mansr.com