[FFmpeg-devel] [PATCH] Vorbis decoder channel layout support

Robert Swain robert.swain
Mon Sep 21 08:11:25 CEST 2009


Hey,

2009/9/21 Diego Biurrun <diego at biurrun.de>:
> On Sun, Sep 20, 2009 at 11:03:04PM +0200, Robert Swain wrote:
>> $subject
>>
>> --- libavcodec/vorbis_dec.c ? (revision 19930)
>> +++ libavcodec/vorbis_dec.c ? (working copy)
>> @@ -954,6 +954,11 @@
>>
>> + ? ?if (avccontext->channels > 6) {
>> + ? ? ? ?avccontext->channel_layout = 0;
>> + ? ?} else
>> + ? ? ? ?avccontext->channel_layout = ff_vorbis_channel_layouts[avccontext->channels - 1];
>> +
>
> I'd say you should either use no {} or place them after the else as
> well.

I'm happy with either, but before Michael has said that if it saves a
line, {} can be omitted.

Regards,
Rob



More information about the ffmpeg-devel mailing list