[FFmpeg-devel] [PATCH] Store Major brand, Minor version and compatible brands of a mov file using the metadata API

[haim alon]

Hi,

On Thu, Sep 17, 2009 at 8:53 PM, Baptiste Coudurier <
baptiste.coudurier at gmail.com> wrote:

> Hi,
>
> ...


> Please remove the special treatment of compatible brands.
> It should be one get_buffer only, and compatible_brands_num is useless: it
> will be strlen(compatible_brands)/4.
>
>
OK, one call to get_buffer to get the compatible brands list (no
verification) and there is no need to deliver compatible_brands_num.



> Besides, as an overall comment, too much code is needed to export metadata,
> but that's not your fault.
> Especially these array declarations, snprintf, av_metadata_set for ints
> really annoy me, this should be simplified by adding av_metadata_set_int or
> something.
>
>
> --
> Baptiste COUDURIER
> Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
> FFmpeg maintainer                                  http://www.ffmpeg.org
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at mplayerhq.hu
> https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel
>

Update attached.

Thanks,
Haim.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ffmpeg.compatible.patch
Type: text/x-patch
Size: 1772 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090922/ee23d422/attachment.bin>