[FFmpeg-devel] [PATCH] mov reference files search improvement

[Diego Biurrun]

On Wed, Sep 23, 2009 at 08:48:48AM +0300, Maksym Veremeyenko wrote:
> 
> Please, comment, commit or reject.
> 
> --- libavformat/mov.c.step1	2009-09-10 08:47:11.000000000 +0300
> +++ libavformat/mov.c	2009-09-18 09:24:41.000000000 +0300
> @@ -1542,6 +1542,56 @@
>  
> +        /* find a source dir */
> +#ifdef __MINGW32__
> +        src_path = FFMAX(strrchr(src, '/'), strrchr(src, '\\'));
> +#else
> +        src_path = strrchr(src, '/');
> +#endif

There must be a way to achieve this without ugly #ifdefs.

> +            if ('/' == ref->path[l]) {
> +                if(i == ref->nlvl_to - 1) break;
> +                else                      i++;

if (

And this looks weird with the statement on the same line

> --- libavformat/mov.c	(revision 19804)
> +++ libavformat/mov.c	(working copy)
> @@ -274,19 +274,36 @@
>  
> +            /* read next level up_from_alias/down_to_target */
> +            dref->nlvl_from = get_be16(pb);
> +            dref->nlvl_to = get_be16(pb);

align

Diego