[FFmpeg-devel] [PATCH] simplify dnxhd threading

Alexander Strange astrange
Sat Sep 26 08:45:25 CEST 2009


On Sat, Sep 26, 2009 at 1:31 AM, Mike Melanson <mike at multimedia.cx> wrote:
> Reimar D?ffinger wrote:
>>
>> On Fri, Sep 25, 2009 at 10:51:36AM -0700, Baptiste Coudurier wrote:
>>>
>>> 68 contexts, even when not using threads ? I'm concerned about memory.
>>
>> Yes, that probably should be checked. Though I think that giving each
>> thread
>> its own whole context is overdoing it anyway.
>
> Thanks for the patch. I vastly simplified the Theora multithreading
> prototype. Instead of copying the whole VP3 context like I did when modeling
> after the dnxhd encoder, I made a new structure that only contains a single
> int-- the slice number to be processed. Then I submit 68 slices to the
> thread dispatcher for processing.
>
> ...and it still doesn't work quite right.
>
> --
> ? ?-Mike Melanson

I had these patches in an old git branch; they might help, though I
didn't see much speed up.
The Theora decoder spends much more time doing linear searches than it
does actually decoding, IIRC.

And I don't mean to submit patch 4 yet, the "enc->thread_count=" lines
should be deleted from ffplay/ffmpeg too.

(and could you look at
http://article.gmane.org/gmane.comp.video.ffmpeg.devel/95138/?)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Simplify-if-statement.patch
Type: application/octet-stream
Size: 1015 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090926/5bb58cf7/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Dynamically-allocate-VP3-qscale_table.patch
Type: application/octet-stream
Size: 1719 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090926/5bb58cf7/attachment-0001.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Dynamically-allocate-VP3-edge_emu_buffer.patch
Type: application/octet-stream
Size: 1407 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090926/5bb58cf7/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-Call-avcodec_thread_init-before-avcodec_open.patch
Type: application/octet-stream
Size: 1278 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090926/5bb58cf7/attachment-0003.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-Slice-multithreading-for-Theora.patch
Type: application/octet-stream
Size: 5056 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090926/5bb58cf7/attachment-0004.obj>



More information about the ffmpeg-devel mailing list