[FFmpeg-devel] [PATCH] id3v2: read TXXX frames

[Måns Rullgård]

Michael Niedermayer <michaelni at gmx.at> writes:

>> +        val = dst + FFMIN(dstlen - 1, strlen(dst)) + 1;
>
> FFMIN(dstlen, strlen(dst) + 1);

Both of those will evaluate strlen() twice, leaving us at the mercy of
the compiler to optimise it out.  I'm not sure that's a good idea.

-- 
M?ns Rullg?rd
mans at mansr.com