[FFmpeg-devel] [PATCH] Fix DV uninitialized reads

[Baptiste Coudurier]

On 9/29/09 4:52 AM, Reimar D?ffinger wrote:
> On Mon, Sep 21, 2009 at 02:40:51PM +0200, Reimar D?ffinger wrote:
>> Hello,
>> I think this fixes the uninitialized data in the DV encoder that causes
>> sporadic "make test" failures, at least valgrind complains no longer.
>> Quick measurements with "time" indicate a slowdown by about 0.8%.
>> regression test values for the encoded files changes (memset to 0
>> instead of 0xff might avoid that though), but the decoded data
>> stays the same - so at least for the cases "make test" covers it is
>> correct.
>
> Ok, a different version.
> It uses s->sys->block_sizes even though I think it pointlessly bloats
> and complexifies the code, it memsets to 0xff still because the
> regression tests change anyway and the spec does not say anything about
> which value to use, and it returns -1 if the bitstream wrote too far,
> even though the return value is not checked anywhere.

Humm, yet it bloats the code indeed, sorry, commit this patch with the 
old check against size_in_bits.

[...]

-- 
Baptiste COUDURIER
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
FFmpeg maintainer                                  http://www.ffmpeg.org