[FFmpeg-devel] [PATCH] Support uncompressed PCX scanlines

[Michael Niedermayer]

On Tue, Sep 29, 2009 at 09:10:39PM +0000, Carl Eugen Hoyos wrote:
> Peter Ross <pross <at> xvid.org> writes:
> 
> > Sample here: http://roundup.ffmpeg.org/roundup/ffmpeg/issue1411
> 
> [...]
> 
> > +    if (encoding == 0) {
> 
> It should be (!encoding)
> 
> > +        memcpy(dst, src, bytes_per_scanline);
> > +        src += bytes_per_scanline;
> > +    } else {
> 
> And I believe I remember Michael saying once that he slightly prefers
> if (condition) { //instead of if (!condition)
> ...
> } else {
> ...
> }

indeed, though iam not sure in this case, a
if(encoding==0)
else if(encoding==1)
else if(encoding==2)
...

also has its appeal. Of course theres no ==2 ... in the code and i dont know
if they are in the spec ...

i guess this is all rather minor ...


> 
> Apart from that, since Ivo did not send an email this month, I'd say just threat
> to apply!

yes ...
i guess one could try to send ivo a priv mail or CC him but it seems a
little silly for a simple change like this ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The educated differ from the uneducated as much as the living from the
dead. -- Aristotle 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090929/5f8b181a/attachment.pgp>