[FFmpeg-devel] [PATCH] use MANGLE in cavsdsp_mmx.c

[Reimar Döffinger]

On Wed, Sep 30, 2009 at 08:11:50PM +0100, M?ns Rullg?rd wrote:
> Michael Niedermayer <michaelni at gmx.at> writes:
> > On Wed, Sep 30, 2009 at 05:16:07PM +0100, M?ns Rullg?rd wrote:
> >>  h264dsp_mmx.c |   19 +++++++++----------
> >>  1 file changed, 9 insertions(+), 10 deletions(-)
> >> 6c6cb8ff65ca5351ede786f522ad9e188b256ca3  h264_x86_mangle.patch
> >
> > ok if tested and its faster or fixes some problem
> 
> I haven't benchmarked it, and I don't know if it fixes any problem.
> The crashes on openbsd were apparently caused by something else.  I
> figured it was better to post the patch here than leave to rot on my
> disk.  I don't even remember why I wrote it.  Maybe Reimar does, IIRC
> he was watching as I wrote it.

IIRC you were hacking around to fix the OpenBSD H.264 failures and in the
process came over a few compilation problems.
I think they were caused by HAVE_EBX being wrongly set and thus HAVE_7REGS
so I don't think there is a real issue with the code (except a possible
speed difference - no idea about that).