[FFmpeg-devel] [PATCH] RTMP seek support

[Howard Chu]

Stefano Sabatini wrote:
> On date Thursday 2010-04-01 15:36:26 -0700, Howard Chu encoded:
>> Michael Niedermayer wrote:
>>> On Thu, Apr 01, 2010 at 01:11:24PM -0700, Howard Chu wrote:
>>>> Michael Niedermayer wrote:
> [...]
>>>>> also you mix AVERROR_NOTSUPP with AVERROR(ENOSYS)
>>>>
>>>> They are identical. AVERROR_NOTSUPP is defined to AVERROR(ENOSYS) in
>>>> libavutil/error.h.
>>>
>>> currently yes, and maybe always so but i prefer code that does not
>>> depend on such assumtations
>>
>> OK, I'll just use AVERROR(ENOSYS).
>
> No, I believe you should always use AVERROR_NOTSUPP, check this post:
> http://thread.gmane.org/gmane.comp.video.ffmpeg.devel/106104/focus=106778

Judging from that thread, and particularly this note

> Currently we have just one use of AVERROR_NOTSUPP:
>
> in libavformat/file.c:

I would say the prevailing practice is to use AVERROR(ENOSYS). (Of course, 
because I listened to you last time around, now there are two uses, one in 
librtmp.c too. But it looks to me like that should have just been 
AVERROR(ENOSYS) as well.)

-- 
   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/