[FFmpeg-devel] [PATCH] Redefine AVERROR_EOF as a specific FFmpeg error code at the next lavu major bump

[Michael Niedermayer]

On Sat, Apr 03, 2010 at 05:08:48PM +0200, Stefano Sabatini wrote:
> On date Sunday 2010-03-14 20:01:16 +0100, Michael Niedermayer encoded:
> > On Sat, Mar 13, 2010 at 09:20:21PM +0100, Stefano Sabatini wrote:
> > > Hi, $subj.
> > > -- 
> > > FFmpeg = Fast & Fierce Mastodontic Plastic Easy Guide
> > 
> > >  error.h |    3 ++-
> > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > > 0e189262c6eff5c66cb595e68e06d46cccedd7e4  0005-Change-the-definition-of-AVERROR_EOF-at-the-next-lib.patch
> > > >From aff03d4184558d02b6f20605eb1adc32a9eade39 Mon Sep 17 00:00:00 2001
> > > From: Stefano Sabatini <stefano.sabatini-lala at poste.it>
> > > Date: Sat, 13 Mar 2010 21:17:06 +0100
> > > Subject: [PATCH 5/5] Change the definition of AVERROR_EOF at the next libavutil major bump,
> > >  using an FFmpeg specific error code rather than EPIPE, which has a
> > >  quite different semantics.
> > 
> > there are matches for EPIPE in the source, i am thus not in favor of this
> > patch because you wont debug and fix the resulting bugs rather i would
> > have too.
> 
> Apart from some occurrences which I addressed in other patches, there
> are some matches of AVERROR(EPIPE) in rtspenc.c:rtsp_write_packet()
> where its use looks correct (from a chat with Martin: "we're trying to
> send data, but the server closed the connection for some reason").
> 
> Regression test passed (both with LIBAVUTIL_MAJOR_VERSION == 50 and ==
> 51).

bumping it to 51 will changes the codes returned by all libs using libavutil
all of them would need to bump major.
i dont think this is reasonable, thus we should undo all error redefinitions
before they become real and debian burns you at the stake

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Freedom in capitalist society always remains about the same as it was in
ancient Greek republics: Freedom for slave owners. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100403/2801cf69/attachment.pgp>