[FFmpeg-devel] [PATCH] RTMP seek support

[Howard Chu]

Michael Niedermayer wrote:
> On Thu, Apr 01, 2010 at 03:36:26PM -0700, Howard Chu wrote:
>> Michael Niedermayer wrote:
>>> On Thu, Apr 01, 2010 at 01:11:24PM -0700, Howard Chu wrote:
>>>> Michael Niedermayer wrote:
>>>>> now i see what you meant by that this will need to be changed again
>>>>> either way this does not implement the new API correctly
>>>>
>>>> It's simply based on the behavior of avformat_seek_file(). I just aimed
>>>> at
>>>> producing the same result for non-streams, while giving the protocol
>>>> handler read_seek a chance to run.
>>>
>>> the behavior of above in case av_url_read_fseek() is used seems to
>>> differ quite a bit from what the new api docs expect
>>
>> What docs? find|grep in ffmpeg/doc doesn't have any hits on read_seek2.
>
> avformat.h

>   * @NOTE This is part of the new seek API which is still under construction.
>   *       Thus do not use this yet. It may change at any time, do not expect
>   *       ABI compatibility yet!
>   */
> int avformat_seek_file(AVFormatContext *s, int stream_index, int64_t min_ts, int64_t ts, int64_t max_ts, int flags);

>> The end result is identical to the avformat_seek_file() case where
>> read_seek2() does not exist, so how can the behavior be different? If
>> that's true then avformat_seek_file() is also broken.
>
> We change the API because the old was incapable of some things.
> Thus it is not possible to emulate the new over the old. And
> the fallback code does just a best effort ...

OK, then I should just drop the read_seek2 out of my patch then. Without 
support at the ByteIOContext and URLProtocol it can't be implemented anyway.
-- 
   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/