[FFmpeg-devel] [RFC] eval API review

[Michael Niedermayer]

On Fri, Apr 02, 2010 at 06:32:31PM +0200, Stefano Sabatini wrote:
> Hi all,
> 
> it has been mentioned many times that the eval API should be moved
> from lavc to lavu and make it public, where it could be used by
> non-lavc dependant applications and libraries (e.g. libswscale and
> libavfilter).
> 
> Michael also mentioned that he wanted to review the API before to make
> it public, follows an attempt at it.

a review of the existing API is in the form of
pieces of code of the existing api (that is .h file) interleaved with
comments about them like what you consider bad and why.
Iam completely puzzled about what you did or why
we have a existing api that is well tested and well working it just is
missing a review to make sure its future proof and fit for being made
public. You here post a changes api mixing cosmetic and functional
changes and its not even a patch nor do you explain why you made
these changes.
summary everything you did does not belong to a review
everything that does belong to a review is missing
a review implicates no changes

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No snowflake in an avalanche ever feels responsible. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100404/6d0c2464/attachment.pgp>