[FFmpeg-devel] [patch]MMS protocol over TCP

[zhentan feng]

Hi

On Thu, Apr 8, 2010 at 3:04 AM, Michael Niedermayer <michaelni at gmx.at>wrote:

> On Thu, Apr 08, 2010 at 01:52:26AM +0800, zhentan feng wrote:
> [...]
> [...]
> > ===================================================================
> > --- mmst.c    (revision 5735)
> > +++ mmst.c    (working copy)
> > @@ -321,6 +321,8 @@
> >                              mms->asf_header =
> av_realloc(mms->asf_header,
> >                                                mms->asf_header_size
> >                                                + mms->pkt_buf_len);
> > +                            if (!mms->asf_header)
> > +                                return -1;
>
> thats probably a memleak and should return ENOMEM
>
>
fixed.

> [...]
> > @@ -563,10 +563,14 @@
> >      int err = AVERROR(EIO);
> >      int ret;
> >
> > +    h->is_streamed = 1;
> > +    h->priv_data = av_mallocz(sizeof(MMSContext));
> > +    mms = (MMSContext *) h->priv_data;
>
> that cast should be unneeded
>
> fixed.

I attached the new version patch below.
zhentan
-- 
Best wishes~
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mmst_6.patch
Type: application/octet-stream
Size: 26605 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100408/31b756d4/attachment.obj>