[FFmpeg-devel] [PATCH 08/21] Rename ff_parse() to ff_parse_expr().

Michael Niedermayer michaelni
Mon Apr 12 19:45:13 CEST 2010


On Mon, Apr 12, 2010 at 07:34:48PM +0200, Stefano Sabatini wrote:
> On date Monday 2010-04-12 17:02:52 +0200, Michael Niedermayer encoded:
> > On Mon, Apr 12, 2010 at 12:40:24AM +0200, Stefano Sabatini wrote:
> > > On date Sunday 2010-04-11 01:01:20 +0200, Stefano Sabatini encoded:
> > > > The new name is more expressive and fits better in the overall naming
> > > > scheme for the revisited eval API.
> > > 
> > > Ping.
> > 
> > appears to be ok, though i might change my oppinion once i see all the
> > final names together but for now ok
> 
> The names of the eval API functions after the application of this
> patch will result like this:
> 
> ff_parse_expr()
> ff_eval_expr()
> ff_parse_and_eval_expr()
> ff_free_expr()

let me elaborate on what i felt unsure about

expr in the above names sometimes refers to an AVExpr struct and sometimes
refers to a char*
thats no major issue just might be slightly confusing to some people

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is dangerous to be right in matters on which the established authorities
are wrong. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100412/eaa29038/attachment.pgp>



More information about the ffmpeg-devel mailing list