[FFmpeg-devel] [PATCH] don't override file duration?with?bitrate guessed duration

Michael Niedermayer michaelni
Tue Apr 13 16:35:04 CEST 2010


On Tue, Apr 13, 2010 at 01:14:08PM +0000, Joakim Plate wrote:
> Michael Niedermayer <michaelni <at> gmx.at> writes:
> 
> > > 
> > > Right, so stream durations from bitrate of streams, but total duration from
> > > file header? That might be as easy as dropping the check for a previous
> > > file duration in fill_from_bitrate, and keeping the part in this patch
> > > avoids overwriting this value with whatever is in the streams.
> > 
> > mans complained about all the guessing we do and i think he has a point
> > with that.
> > What is the point in filling in stream durations in ways that simply are
> > not precisse?
> > 
> > [...]
> 
> 
> I absolutely agree. I just thought that was what you asked for. 
> 
> So you don't want the stream durations to be populated at all if the demuxer 
> doesn't fill them and they can't be deduced from timestamps?

exactly

> 
> Ie never fill them from bitrate nor from a fileduration?

yes, there maybe exceptions like if a demuxer itself knows this is exact
though

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The misfortune of the wise is better than the prosperity of the fool.
-- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100413/a16aa903/attachment.pgp>



More information about the ffmpeg-devel mailing list