[FFmpeg-devel] [PATCH] split off h264_mb.h from h264.h

[Michael Niedermayer]

On Wed, Apr 14, 2010 at 02:19:10AM +0100, M?ns Rullg?rd wrote:
> Diego Biurrun <diego at biurrun.de> writes:
> 
> > On Wed, Apr 14, 2010 at 02:42:24AM +0200, Michael Niedermayer wrote:
> >> On Wed, Apr 14, 2010 at 01:05:40AM +0200, Diego Biurrun wrote:
> >> > This patch splits off a separate header file for decode_mb_skip() and
> >> > friends from h264.h.  I consider it a sensible idea in general and it
> >> > eliminates more of those pesky 'defined but not used' warnings.
> >> > 
> >> > Since this just moves static functions like my previous patch I assume
> >> > it is similarly safe.  OK to apply?
> >> > 
> >> >  h264.h       |  541 -------------------------------------------
> >> >  h264_cabac.c |    1 
> >> >  h264_cavlc.c |    1 
> >> >  h264_mb.h    |  735 -----------------------------------------------------------
> >> 
> >> iam against this patch. The placement of code into files becomes random
> >> with it and merely guided by avoidance of silly warnings
> >> these warnings should be disabled!
> 
> Over my dead body.

I can mark the functions as av_unused if you prefer that


> 
> > I beg to differ.  h264.h is huge at 1300 lines of code and it's just a
> > grab bag of many things H.264-related with no particular order or
> > structure.  Splitting the macroblock code off from it is not making
> > things more random and is not just guided by warning avoidance.
> 
> In this case, the warnings are working exactly as intended.  Unused
> functions being visible to the compiler are a sign of bad structure.

the patch doesnt improve the structure.
And we have hundreads of unused static inline functions in headers, and
any solution to that would make the code worse.
split headers based on 1 function per header or #ifdef around every function

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The bravest are surely those who have the clearest vision
of what is before them, glory and danger alike, and yet
notwithstanding go out to meet it. -- Thucydides
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100414/cd728767/attachment.pgp>