[FFmpeg-devel] [PATCH] split off h264_mb.h from h264.h

[Diego Biurrun]

On Wed, Apr 14, 2010 at 03:45:38AM +0200, Michael Niedermayer wrote:
> On Wed, Apr 14, 2010 at 03:03:55AM +0200, Diego Biurrun wrote:
> > On Wed, Apr 14, 2010 at 02:42:24AM +0200, Michael Niedermayer wrote:
> > > On Wed, Apr 14, 2010 at 01:05:40AM +0200, Diego Biurrun wrote:
> > > > This patch splits off a separate header file for decode_mb_skip() and
> > > > friends from h264.h.  I consider it a sensible idea in general and it
> > > > eliminates more of those pesky 'defined but not used' warnings.
> > > > 
> > > > Since this just moves static functions like my previous patch I assume
> > > > it is similarly safe.  OK to apply?
> > > > 
> > > >  h264.h       |  541 -------------------------------------------
> > > >  h264_cabac.c |    1 
> > > >  h264_cavlc.c |    1 
> > > >  h264_mb.h    |  735 -----------------------------------------------------------
> > > 
> > > iam against this patch. The placement of code into files becomes random
> > > with it and merely guided by avoidance of silly warnings
> > > these warnings should be disabled!
> > 
> > I beg to differ.  h264.h is huge at 1300 lines of code and it's just a
> > grab bag of many things H.264-related with no particular order or
> > structure. Splitting the macroblock code off from it is not making
> > things more random and is not just guided by warning avoidance.
> 
> i dont see the relation between what you say and what your patch does

Maybe you would prefer another name for the header file?
h264_cabac_cavlc.h perhaps?  decode_mb_skip is not an inline function,
maybe you would prefer to place it in a .c file instead?

Diego