[FFmpeg-devel] [PATCH] H264: avctx->{profile, level} init down to SPS

Michael Niedermayer michaelni
Wed Apr 14 15:31:32 CEST 2010


On Wed, Apr 14, 2010 at 09:50:17AM +0200, Gwenole Beauchesne wrote:
> Hi,
>
> Similarly to the avctx->refs patch, this one moves other {profile,level} 
> fields initialization below.
>
> BTW, this reminds me that h264_parser.c probably needs to set avctx->refs 
> too?

this would create a race condition between decoder and parser if they
run in seperate threads


>
> Regards,
> Gwenole.

>  h264.c |    8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 54e5572f90523ebba27314f7dd0d751e83461f7b  ffmpeg.h264.profile+level.patch
> commit 8a7390d0d3273073dd4e0faab32d4665c0aa0bd2
> Author: Gwenole Beauchesne <gbeauchesne at splitted-desktop.com>
> Date:   Wed Apr 14 07:14:54 2010 +0200
> 
>     Move avctx->{profile,level} initialization down to SPS.

same problem as with refs.
If you think its ok, quote the spec that says these may never change,
maybe the spec says something like that ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have often repented speaking, but never of holding my tongue.
-- Xenocrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100414/822b9039/attachment.pgp>



More information about the ffmpeg-devel mailing list