[FFmpeg-devel] r22718 in libavformat/rtsp.c uses non-portable errno

[Ramiro Polla]

On Thu, Apr 15, 2010 at 3:28 PM, Ronald S. Bultje <rsbultje at gmail.com> wrote:
> On Sat, Apr 10, 2010 at 4:08 PM, Ronald S. Bultje <rsbultje at gmail.com> wrote:
>> On Sat, Apr 10, 2010 at 1:40 PM, Ramiro Polla <ramiro.polla at gmail.com> wrote:
>>> the output of rtsp.o is binary identical to my patch.
>>>
>>> There's also another occurrence in cmdutils.c, and I think we should
>>> enclose the error with (), such as
>>> -#define ff_neterrno() WSAGetLastError()
>>> -#define FF_NETERROR(err) WSA##err
>>> +#define ff_neterrno() (-WSAGetLastError())
>>> +#define FF_NETERROR(err) (-WSA##err)
>>
>> OK, I'm not at the computer much this weekend, so expect me to apply
>> with those modifications on Monday, unless you do it earlier.
>
> And... Applied.

Thanks!