[FFmpeg-devel] [PATCH 2/2] Autodetect pthreads

[Jason Garrett-Glaser]

2010/4/19 M?ns Rullg?rd <mans at mansr.com>:
> Jason Garrett-Glaser <darkshikari at gmail.com> writes:
>
>> 2010/4/19 M?ns Rullg?rd <mans at mansr.com>:
>>> David Conrad <lessen42 at gmail.com> writes:
>>>
>>>> On Apr 19, 2010, at 9:01 AM, M?ns Rullg?rd wrote:
>>>>
>>>>> David Conrad <lessen42 at gmail.com> writes:
>>>>>
>>>>>> ? ?Autoenable pthreads for libx264
>>>>>>
>>>>>> diff --git a/configure b/configure
>>>>>> index 959d63b..d2ec4c1 100755
>>>>>> --- a/configure
>>>>>> +++ b/configure
>>>>>> @@ -2579,6 +2579,11 @@ pthreads_if_any='
>>>>>> ? ? mpeg2video_encoder
>>>>>> '
>>>>>>
>>>>>> +# autoenable pthreads if the external lib is likely to depend on them
>>>>>> +if ! disabled pthreads; then
>>>>>> + ? ?enabled libx264 && enable pthreads
>>>>>> +fi
>>>>>
>>>>> This will break if any other threading lib is selected.
>>>>
>>>> Oops
>>>
>>> Seriously, this is getting uglier each time. ?What exactly are you
>>> trying to achieve?
>>
>> Currently, if a user compiles with --enable-libx264 without
>> --enable-pthreads, ffmpeg will break.
>
> Works fine with shared libx264.
>
>> This is stupid suboptimal behavior. ?Furthermore, there is no reason
>> ffmpeg shouldn't have pthreads by default,
>
> For those who do not want or need pthreads, enabling it by default
> will be an annoyance. ?Until you can make it read people's minds, it
> will always be wrong for someone.

For those who do not want or need zlib, enabling it by default will be
an annoyance.  Until you can make it read people's minds, it will
always be wrong for someone.

So we should disable zlib now too, right?

ffmpeg should default to what the majority of users want.  The
majority of users are willing to sacrifice a few kilobytes of code for
thread support.  If you think otherwise, you are wrong.

Dark Shikari