[FFmpeg-devel] [PATCH] Override datadir via environment variable

[Ronald S. Bultje]

Hi,

2010/4/16 Robert Kr?ger <krueger at signal7.de>:
>
> On 16.04.2010, at 10:44, Robert Kr?ger wrote:
>> On 15.04.2010, at 20:17, Ronald S. Bultje wrote:
>>> On Thu, Apr 15, 2010 at 2:02 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
>>>> On Wed, Apr 14, 2010 at 11:39:44AM +0200, Robert Kr?ger wrote:
>>>>> the following patch allows to override the data/presets directory via an environment variable FFMPEG_DATADIR.
>>>>>
>>>>> The use cases for this (in my case) are:
>>>>> - You have to deploy ffmpeg on multiple machines but use different locations (that's where the compiled-in default won't help) for presets and you want to either have multiple users use the same presets or simply do not have control (company policies, whatever) over where to put stuff
>>>>> - You want to have a self-contained bundle of scripts and ffmpeg including binary and presets which does not require any installation
>>>>>
>>>>> The lookup order now (directories) is:
>>>>>
>>>>> FFMPEG_DATADIR if set
>>>>> HOME/.ffmpeg if HOME is set
>>>>> compiled in FFMPEG_DATADIR
>>> [..]
>>>>> ffmpeg.c | ? 11 +++++++----
>>>>> 1 file changed, 7 insertions(+), 4 deletions(-)
>>>>> 17cbbae6ae21eca556eb108c53ae57a33300c8b2 ?ffmpeg-override-datadir.patch
>>>>
>>>> if people want this feature, i dont mind, if none of the devels wants it
>>>> then iam against it
>>>
>>> I think it's useful, but this patch lacks documentation thus
>>> completely removing its utility. Please document it in 1-2 locations,
>>> e.g. ffmpeg --help in the relevant part, manpage, etc.
>>
>> OK, planned to do that, once it is clear that the feature will be accepted. I'll post a patch with docs later today.
>
> OK, here it is. I didn't find any other place where the preset lookup mechanism was documented, so I hope this is OK.

Fine with me (and docs are Ok now), but Michael is maintainer.

Ronald