[FFmpeg-devel] [PATCH 1/5] Change eval internal functions, ff_parse_expr() and ff_parse_and_eval_expr() interface.

[Stefano Sabatini]

On date Tuesday 2010-04-20 02:37:55 +0200, Michael Niedermayer encoded:
> On Tue, Apr 20, 2010 at 01:18:01AM +0200, Stefano Sabatini wrote:
[...]
> > > > A possible solution would be to add a simple flag log_error to
> > > > ff_parse_expr()/ff_parse_and_eval_expr().
> > > 
> > > iam against this, its unreasonable unflexible, even a offset to the
> > > log level would be better
> > 
> > Problem with the map is that we don't have just 8 values for log, it
> > is an int ranging from -8 to 48, that's why I can't grasp the 8 entry
> > array map idea, please elaborate.
> 
> right, sorry, i meant something like:
> level += map[av_clip(level>>3,...)]

If I understood it correctly this would mean to set an ad-hoc log
level for each log context, right?

> > Other ideas:
> > // write the error message to the user-provided error buffer, allows
> > // ad-hoc context-sensitive messages
> > int av_parse_expr(..., const char *error, size_t error_size);
> > 
> > or maybe we could just provide more than one interface:
> > av_parse_expr (..., void *log_ctx);
> > av_parse_expr2(..., const char *error, size_t error_size);
> > 
> > Please tell me what you consider acceptable.
> 
> i dont like multiple interfaces, things are complex enough already

So what about the other solution:
int av_parse_expr(..., const char *error, size_t error_size);
?

Regards.
-- 
FFmpeg = Fabulous Fiendish Mere Puristic Explosive Gnome