[FFmpeg-devel] [patch] libswscale: fix warning regarding "no return in non void function"
Dominique Leuenberger
dominique-ffmpeg-devel
Fri Apr 23 09:25:25 CEST 2010
Quoting Michael Niedermayer <michaelni at gmx.at>:
>
> i dont like #ifdefery, the code before was cleaner
Cleaner is arguable. The compiler spits 2 warnings if HAVE_7REGS is
not true. --> If HAVE_7REGS is not true, then the two functions
patched are empty. And if ('COMPILER_DIRECTIVE') is also not THAT
readable.
>
> besides iam seeing "ffmpeg-0.5" in your directory path, you arent
> submitting a patch against 0.5 are you?
No, I could as well call the directory boo-boo. It's historical that
this folder is called 0.5. It's an SVN snapshot from not too far in
the past (the 0.5.0 did not even have this code... )
> Democracy is the form of government in which you can choose your dictator
Makes sense... contextual :)
Dominique
More information about the ffmpeg-devel
mailing list